Already an open datareader associated with this command which must be closed first

Question

1.00/5 (1 vote)

See more:

i m using sql connection i get the the error while i m executing the following code.

C#

SqlCommand cmd = new SqlCommand();
cmd.CommandText = "insert into ticket values(@pnrno,@tno,@seat)";
cmd.Connection = conn;
cmd.Parameters.Add(new SqlParameter("@pnrno", SqlDbType.Int));
cmd.Parameters["@pnrno"].Value = pnr;
cmd.Parameters.Add(new SqlParameter("@tno", SqlDbType.Int));
cmd.Parameters["@tno"].Value = tno;
 int seat = 0;
 if (clas == "firstac")
   {
  string query = "select firstac from vacseat where tno='" + tno + "'";
  SqlCommand cmd2 = new SqlCommand(query, conn);
  SqlDataReader dr = cmd2.ExecuteReader();
  if (dr.Read())
   {
   seat = int.Parse(dr["firstac"].ToString());
    }
  }
cmd.Parameters.Add(new SqlParameter("@seatno", SqlDbType.Int));
cmd.Parameters["@seatno"].Value = seat;
int no=cmd.ExecuteNonQuery();

plz look at this

Posted 9-Nov-11 6:47am

Himu from Orissa

Updated 9-Nov-11 6:48am

Prerak Patel

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Prerak Patel · Answer 1 · 2011-11-09T06:51:00

Solution 1

Close the reader.

C#

 if (clas == "firstac")
   {
  string query = "select firstac from vacseat where tno='" + tno + "'";
  SqlCommand cmd2 = new SqlCommand(query, conn);
  SqlDataReader dr = cmd2.ExecuteReader();
  if (dr.Read())
   {
   seat = int.Parse(dr["firstac"].ToString());
    }
  dr.Close();
  }

Posted 9-Nov-11 6:51am

Prerak Patel

Comments

Himu from Orissa 9-Nov-11 22:30pm

dr is closed but still i get the same exception