retrivte data between two dates

Question

0.00/5 (No votes)

See more:

C#

SqlConnection con = new SqlConnection("Data Source=server;Initial Catalog=f_library;User ID=sa;Password=ahmed");
con.Open();
SqlDataAdapter dad = new SqlDataAdapter("Select * from esrdat where esrdat_date between '" + Convert.ToDateTime(dateTimePicker1.Value) + "' and '" + Convert.ToDateTime(dateTimePicker2.Value) + "'", con); 
DataSet ds = new DataSet();
dad.Fill(ds);
if (ds.Tables[0].Rows.Count > 0)
{
    esrdatDataGridView.DataSource = ds.Tables[0];
}

con.Close();

I get this error

System.Data.SqlClient.SqlException was unhandled
Message="Syntax error converting datetime from character string."

Posted 31-Jan-12 0:14am

iceprincess50

Updated 31-Jan-12 0:17am

lukeer

v2

Add a Solution

Comments

lukeer 31-Jan-12 6:18am

Please wrap code samples in <pre lang="c#">tags like these</pre>
This time, I did it for you.

2 solutions

Solution 2

Try using DateTime.TryParse method[^] to ensure you are converting an appropriate string to DateTime value.

Posted 31-Jan-12 0:30am

Abhinav S

Comments

lukeer 1-Feb-12 2:24am

There is nothing to parse here. DateTimePicker.Value is already a valid DateTime.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2012-01-31T00:33:00

Don't do that!

C#

SqlDataAdapter dad = new SqlDataAdapter("Select * from esrdat where esrdat_date between '" + Convert.ToDateTime(dateTimePicker1.Value) + "' and '" + Convert.ToDateTime(dateTimePicker2.Value) + "'", con);

All it does is take a valid DateTime, use a default conversion to a string, then try to convert it back to a DateTime. Then pass that (as a number, converted back to a string via another default conversion) to SQL. But in your local format, rather than anythign SQL is expecting, which is ISO format.

Try:

C#

SqlDataAdapter dad = new SqlDataAdapter("Select * from esrdat where esrdat_date between @START AND @END", con);
dad.SelectCommand.Parameters.AddWithValue("@START", dateTimePicker1.Value);
dad.SelectCommand.Parameters.AddWithValue("@END", dateTimePicker2.Value);