help copying only files that have a newer date on them with vb.net

Question

0.00/5 (No votes)

See more:

i have an issue where at first we were copying the contects of this folder on form load that had several scripts in it to the local machine but over time that folder has grown where copying all thoses files at once is talking forever.

What i need help doing is changing the code were using now to check if the files has a newer date on it then the one on the local machine and if so then i need it to copy that file if not then just continue to check the other files on the machine.

the code im using now is

VB

Public Sub File_Check_Apps_USMC()
    Dim strSrc As String = "\\mcusquanfs01\NRFZHD\RDM_NRFK_WN7\SynergyLite\Static_Fixes\Application"
    Dim strDest As String = "C:\Program Files (x86)\Synergy\Remote_Fixes\Applications"
    Dim dirInfo As New System.IO.DirectoryInfo(strSrc)
    Dim fsInfo As System.IO.FileSystemInfo

    If Not System.IO.Directory.Exists(strDest) Then
        System.IO.Directory.CreateDirectory(strDest)
    End If

    For Each fsInfo In dirInfo.GetFileSystemInfos
        Dim strDestFileName As String = System.IO.Path.Combine(strDest,
        fsInfo.Name)

        If TypeOf fsInfo Is System.IO.FileInfo Then
            System.IO.File.Copy(fsInfo.FullName, strDestFileName, True)
            'This will overwrite files that already exist
        Else

        End If

    Next

End Sub

help would be great.

Posted 2-Mar-12 14:01pm

Zachary.shupp

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Dave Kreskowiak · Accepted Answer · 2012-03-02T14:26:00

First, you don't need the the If TypeOf fsinfo Is System.Io.FileInfo becuase you're getting nothing but FileInfo objects from the GetFileInfos call. I'm all for defensive coding but that's overkill.

Next, You don't need to put the namespaces ahead of every class, like System.Io.Path.Combine. If you put Imports statements at the top of your file, you don't need to type all that stuff. It just becomes:

Include System.Io
.
.
If Not Directory.Exists(...)

Dim destFileName As String = Path.Combine(...)

Oh, and putting the old Hungarian type prefix on everything is so 1990's. Stop it. Use more descriptive variable names, like destFilepath and sourceFilepath. That garbage was only used when the compiler didn't do type checking for you, such as VBScript. VB.NET is fully type safe. What you're doing is redundant.

Now, on to the problem at hand...

All you have to do is get a FileInfo object for the soruce file and the destination file, then compare the LastWriteTime properties of both. They're different, copy the file. If not, move on to the next file.