Help creating functions for vb.net

Question

0.00/5 (No votes)

See more:

I have been trying t learn how to create my own funtions and need a little help. On everyone i have created i get similar warnings like this:

Warning	1	Function 'GetFileContents' doesn't return a value on all code paths. A null reference exception could occur at run time when the result is used.	C:\Users\Zachary\Desktop\Synergy.079s\Synergy\Modules\Updating.vb	42	5	Synergy

Is this something i shouldn't worry about since it works or should i be adding something to the function for a safety? help would be great.

Public Function GetFileContents(ByVal FullPath As String, Optional ByRef ErrInfo As String = "") As String

    Dim strContents As String
    Dim objReader As StreamReader

    Try
        objReader = New StreamReader(FullPath)
        strContents = objReader.ReadToEnd()
        objReader.Close()
        Return strContents
    Catch Ex As Exception
        ErrInfo = Ex.Message
    End Try

End Function

Posted 4-Mar-12 8:51am

Zachary.shupp

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

André Kraak · Accepted Answer · 2012-03-04T09:06:00

The Catch part of your code does not contain a return statement.

I would change your code and more the return statement at the end of the function.

VB

Public Function GetFileContents(ByVal FullPath As String, Optional ByRef ErrInfo As String = "") As String

    Dim strContents As String = ""
    Dim objReader As StreamReader

    Try
        objReader = New StreamReader(FullPath)
        strContents = objReader.ReadToEnd()
        objReader.Close()
    Catch Ex As Exception
        ErrInfo = Ex.Message
    End Try

    Return strContents

End Function

This way all execution paths return a value.