problem withdrawing from overdraft when balance is 0

Question

1.00/5 (1 vote)

See more:

hey i want to be able to draw from my overdraft when my balance get to 0. here my code could you please direct me in the right direction :)

Posted 16-Mar-12 22:32pm

stefanere2k9

Updated 19-Mar-12 2:35am

v3

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2012-03-16T22:59:00

Solution 1

You seem to be treating an overdraft as a separate account - this seems a little silly.

The way I would do it:
Have a method RequestFunds(amount)
In the method,
1) Add the overdraft limit to the current balance - this is the availableFunds.
2) Check if the requested amount is less than or equal to the availableFunds.
3) If it is, all fine - just go ahead, and subtract the amount from the balance.
4) If it isn't, then you need to report an error and refuse the transaction.

Posted 16-Mar-12 22:59pm

OriginalGriff

Comments

stefanere2k9 18-Mar-12 21:28pm

i have got this code now but it dont seem to be working;
SqlDataReader readdata;
sqlCommandWithdraw.Connection.Open();
decimal balance = decimal.Parse(Txt_Withdraw.Text);
decimal availableTBalance = 0.00M;
sqlCommandWithdraw.Parameters["@accountID"].Value = showaccounts.accountID;
readdata = sqlCommandWithdraw.ExecuteReader();
while (readdata.Read())
{
availableTBalance = (Convert.ToDecimal(readdata["balance"].ToString()) + Convert.ToDecimal(readdata["overdraftlimit"]));
}

sqlCommandWithdraw.Connection.Close();

if (availableTBalance >= balance)
{
sqlCommandUpdateBalance.Connection.Open();
availableTBalance -= balance;
sqlCommandUpdateBalance.Parameters["@balance"].Value = availableTBalance;
sqlCommandUpdateBalance.Parameters["@accountID"].Value = showaccounts.accountID;
sqlCommandUpdateBalance.ExecuteNonQuery();
sqlCommandUpdateBalance.Connection.Close();

OriginalGriff 19-Mar-12 4:26am

There are a couple of things wrong with that, but I don't know if they are relevant to the problem you are having:
1) Don't call it "balance" - it's not, it's the amount they customer wants to withdraw. Calling it "balance" rather than "withdrawlAmount" or similar makes teh code harder to read and understand.
2) Don't use decimal.Parse - use decimal.TryParse instead, and report any bad data to the user - otherwise you could be withdrawi8ng the wrong amount.
3) Don't use a while loop - if you are returning more than one record then you have a problem anyway, so check - with error reporting, and use "if" instead.
4) Be consistent! If "balance" needs ToString, then "overdraftlimit" needs ToString! In fact, neither of them do, and I would just cast them to decimal rather than using Convert.ToDecimal anyway.
5) If this was a genuine app, rather than a homework exercise, I would probably move this into a stored procedure, and lock the account record while I was doing it, as in a multiuser environment it would be possible to make several withdrawals at teh same time, and get them all oked, it the customer was lucky!

Other than that, I need to know what the problem you are having is, as "it dont seem to be working" doesn't tell me a lot about what it does or doesn't do! :laugh: