update column between two dates

Question

1.00/5 (3 votes)

See more:

Hello

Please help me. I tried to update column between two dates. The system commit the method. But it does not take change in the database.

This is the code.

C#

public string AlterValid(DateTime startDate, DateTime endDate)
        {
          

            OleDbConnection conn = new OleDbConnection("My Db setup");
            string status = null;
            bool setToFalse = false;

            
            string updateSql = "UPDATE Watchreceipt SET valid = @valid WHERE Dato BETWEEN @startDate AND @endDate AND DriverIDFK = @DriverIDFK";


            conn.Open();
            OleDbTransaction sqltrans = conn.BeginTransaction();

            try
            {
                OleDbCommand updateCmd = conn.CreateCommand();
                updateCmd.CommandText = updateSql;

                updateCmd.Parameters.AddWithValue("@startDate", startDate);
                updateCmd.Parameters.AddWithValue("@endDate", endDate);
                updateCmd.Parameters.AddWithValue("@DriverIDFK", UserMapper.driverNumber);

                updateCmd.Transaction = sqltrans;
                

                updateCmd.Parameters.Add("@valid", OleDbType.Boolean);
                updateCmd.Parameters["@valid"].Value = setToFalse;

                updateCmd.ExecuteNonQuery();
                sqltrans.Commit();


                status = "Ok";
            }
            catch (OleDbException odbe)
            {
                sqltrans.Rollback();
                System.Windows.Forms.MessageBox.Show("Rolled back\n" + odbe.Message);
            }
            catch (Exception ex)
            {
                System.Windows.Forms.MessageBox.Show("Systemfejl\n" + ex.Message);
            }
            finally
            {
                conn.Close();
            }

            return status;


        }

Please help

Posted 27-Jul-12 3:05am

Sego Turan

Updated 27-Jul-12 3:35am

Wes Aday

v4

Add a Solution

Comments

Prasad_Kulkarni 27-Jul-12 9:07am

Why Re-post??

Sego Turan 27-Jul-12 10:15am

Thank for the comments OriginalGriff. I am new here.
I tryed to use the command outside the block, but it does not change the column.
Can you try to write it, meybe i dont understand it.

I understand it like that.

OleDbConnection conn = new OleDbConnection(My db path));
string status = null;
bool setToFalse = false;

string updateSql = "UPDATE Watchreceipt SET valid = @valid WHERE Dato BETWEEN @startDate AND @endDate AND DriverIDFK = @DriverIDFK";

conn.Open();
OleDbTransaction sqltrans = conn.BeginTransaction();

OleDbCommand updateCmd = conn.CreateCommand();
updateCmd.CommandText = updateSql;

updateCmd.Parameters.AddWithValue("@startDate", startDate);
updateCmd.Parameters.AddWithValue("@endDate", endDate);
updateCmd.Parameters.AddWithValue("@DriverIDFK", UserMapper.driverNumber);

updateCmd.Transaction = sqltrans;

try
{

updateCmd.Parameters.Add("@valid", OleDbType.Boolean);
updateCmd.Parameters["@valid"].Value = setToFalse;

updateCmd.ExecuteNonQuery();
sqltrans.Commit();

status = "Ok";
}
catch (OleDbException odbe)
{
sqltrans.Rollback();
System.Windows.Forms.MessageBox.Show("Rolled back\n" + odbe.Message);
}
catch (Exception ex)
{
System.Windows.Forms.MessageBox.Show("Systemfejl\n" + ex.Message);
}
finally
{
conn.Close();
}

return status;

did I understand it correct?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2012-07-27T03:46:00

Solution 1

For the third time today: use the command from outside the try block, not create a new one inside

And stop posting the same question, before you annoy people...

Posted 27-Jul-12 3:46am

OriginalGriff

Sego Turan · Answer 2 · 2012-07-27T07:41:00

This is the solution.

C#

public string UpdateValid(DateTime startDate, DateTime endDate)
        {
          
            OleDbConnection conn = new OleDbConnection("my db path"));
            string status = null;
            
            string updateSql = "UPDATE Watchreceipt SET valid = false WHERE Dato BETWEEN @startDate AND @endDate AND DriverIDFK = @DriverIDFK";

            conn.Open();
            OleDbTransaction sqltrans = conn.BeginTransaction();
            OleDbCommand updateCmd = conn.CreateCommand();
            updateCmd.CommandText = updateSql;
            
            updateCmd.Parameters.AddWithValue("@startDate", startDate);
            updateCmd.Parameters.AddWithValue("@endDate", endDate);
            updateCmd.Parameters.AddWithValue("@DriverIDFK", UserMapper.driverNumber);

            updateCmd.Transaction = sqltrans;

            try
            {
                
                updateCmd.ExecuteNonQuery();
                sqltrans.Commit();
                
                status = "Ok";
            }
            catch (OleDbException odbe)
            {
                sqltrans.Rollback();
                System.Windows.Forms.MessageBox.Show("Rolled back\n" + odbe.Message);
            }
            catch (Exception ex)
            {
                System.Windows.Forms.MessageBox.Show("Systemfejl\n" + ex.Message);
            }
            finally
            {
                conn.Close();
            }

            return status;


        }

I changed the SQL statement and deleted some code inside the try block.
Thanks