How do I turn the attached code into async C#

Question

0.00/5 (No votes)

See more:

C#

<pre>public static bool DisplayOriginalFiles(List<string> files)
{
	string fileName = string.Empty;
	string filePath = string.Empty;
	// Loop through Files and display data while building Observable Collection
	foreach (string file in files)
	{
					{// Get the original FileName
			fileName=Path.GetFileName(file);

			// Separate Path from FileName
			filePath=file.Replace(fileName,"");

			// Display and Load Rename Observable Collection with Original File Name
			Gbl.rO.Add(new RenameObservable(fileName,"","Orig Loaded",true,true,filePath,file));
		}	
	}
	return true;
}

I execute with the following:

C#

// Display Original Files to User
Common.DisplayOriginalFiles(selectedFiles);

The reason I want to make it async is because I want each renameobservable to come on the screen up one at a time rather than all at once.

Or is there another way to make this happen?

What I have tried:

Tried putting await in but will not allow me to do that.

Posted 18-Sep-24 23:54pm

Leonard Salamacha 2023

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Answer 1 · 2024-09-19T00:34:00

There's nothing in your code that lends itself to being async. If you want the items to appear one at a time, then you'll need to add a delay between adding them - for example:

C#

public static async Task<bool> DisplayOriginalFiles(List<string> files)
{
    TimeSpan delayTime = TimeSpan.FromSeconds(0.5);
    
    foreach (string file in files)
    {
        string fileName = Path.GetFileName(file);
        string filePath = Path.GetDirectoryName(file);
        Gbl.rO.Add(new RenameObservable(fileName, "", "Orig Loaded", true, true, filePath, file));
        
        // Pause before adding the next item:
        await Task.Delay(delayTime);
    }
    
	return true;
}

NB: Your method of getting the file path is dangerously wrong. The file name could appear earlier in the path, which would result in you looking in the wrong folder. Eg: C:\passwords.txt\Windows\System32\passwords.txt would yield a path of C:\\Windows\System32\, which is just wrong.

Use the Path.GetDirectoryName to extract the path, rather than trying to roll your own.

George Swan · Answer 2 · 2024-09-19T21:51:00

The problem with Observables is that they push the data at the comsumer. If you want control the receipt of the data then a pull based system is probably better. AsyncStreams are ideal for this purpose as the async process is pull based. You have the ability to process an item from the stream before other items become available. Something along these lines.

C#

  internal class Program
 {
  public  static async IAsyncEnumerable <string? > ReadLines(string path)
  {
    using StreamReader stream = File.OpenText(path);
    while (stream.EndOfStream is false)
     {
      //return the line as soon as it is available
      yield return await stream.ReadLineAsync();
      Console.WriteLine("Next stream request");
      
     }
   }  
 

    static async Task Main()
  {
    await foreach (var line in ReadLines(@"C:\Temp\Test.txt"))
    {
      //do something with the line
      Console.WriteLine(line);
      Console.WriteLine("zzzzz");
      await Task.Delay(4000);

    }
    
    Console.ReadLine();
  }
}

How do I turn the attached code into async C#

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0