Catch block is not executed......Please help

Question

4.00/5 (1 vote)

See more:

Hello Team ,

I have simple application in windows form which displays records from database into ListView.

This is my Table :

Collapse | Copy Code

NAME   EDUCATION   SKILLS   EXP 
 
  A       BE        JAVA     1

I have two textBoxes for SKILLS and EXP ,It shows records according its selection

So I want to show error message for selection which is not in my table . However I am not getting error message.

This is my code ....Please help me

C#

private void Search_Click(object sender, EventArgs e)
{
   try
   {
      SqlConnection objCon = new SqlConnection("Data Source=OM-PC; Initial Catalog=master; Integrated Security=True");
      SqlDataAdapter objAdapt = new SqlDataAdapter("SELECT * FROM VACANCY WHERE SKILLS='" + textBox1.Text + "'and EXPERIENCE='" + textBox5.Text + "'", objCon);
 
      DataTable objDT = new DataTable();
      objAdapt.Fill(objDT);
      //now initialize listview
      // Set the view to show details.
      listView2.View = View.Details;
      // Allow the user to edit item text.
      listView2.LabelEdit = true;
      // Allow the user to rearrange columns.
      listView2.AllowColumnReorder = true;
      // Select the item and subitems when selection is made.
      listView2.FullRowSelect = true;
      // Display grid lines.
      listView2.GridLines = true;
      // Sort the items in the list in ascending order.
      // listView1.Sorting = SortOrder.Ascending;
      //finally fill listview
      for (int i = 0; i < objDT.Rows.Count; i++)
      {
         //    listView2.Enabled = true;

         DataRow objDR = objDT.Rows[i];
         ListViewItem listitem = new ListViewItem(objDR["JOBCODE"].ToString());
         listitem.SubItems.Add(objDR["COMPANY"].ToString());
 
         listitem.SubItems.Add(objDR["SKILLS"].ToString());
         listitem.SubItems.Add(objDR["EXPERIENCE"].ToString());
         listitem.SubItems.Add(objDR["POST"].ToString());
         listitem.SubItems.Add(objDR["POSTED"].ToString());
 
         listView2.Items.Add(listitem);
      }
   }
   catch (Exception)
   {
      MessageBox.Show("No Records Found", "", MessageBoxButtons.OK, MessageBoxIcon.Error);
   }
}

Posted 21-May-14 2:13am

Member 10272175

Updated 21-May-14 2:18am

CPallini

v2

Add a Solution

Comments

[no name] 21-May-14 8:21am

Not having a record in your database is not an exception.

3 solutions

Solution 1

That's the correct behaviour, since, from SqlDataAdapter's documentation[^]:

If a command does not return any rows, no tables are added to the DataSet, and no exception is raised.

You might throw yourself the exception (or simply show directly the error message) when objDT.Rows.Count is 0.

Posted 21-May-14 2:28am

CPallini

v2

Solution 3

Look first thing is if no records found it is not a kind of exception.

Still if you want to get it as exception you can through your custom exception as mentioned below :-

Ex :

C#

try
{
        if(objDT.Rows.Count <= 0){
        throw new Exception("No Records found.");
    }else{
        //do operations on the records iterating through it
    }

}
catch (Exception ex)
{
    if (ex.Message == "No Records found.")
        {
        MessageBox.Show("No Records Found", "", MessageBoxButtons.OK, MessageBoxIcon.Error);
        }
}

OR

You can also directly show the message-box directly at place where you are getting no records in the IF condition satisfaction.

Hope this will definitely be of help, else let me know if any further concerns are there.

Posted 21-May-14 2:35am

SRS(The Coder)

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

nilschaudhari · Accepted Answer · 2014-05-21T02:29:00

Hi,

include the following code into your code for displaying the message

C#

if(objDT.Rows.Count>0)
{
   for (int i = 0; i < objDT.Rows.Count; i++)
      {
         //    listView2.Enabled = true;

         DataRow objDR = objDT.Rows[i];
         ListViewItem listitem = new ListViewItem(objDR["JOBCODE"].ToString());
         listitem.SubItems.Add(objDR["COMPANY"].ToString());
 
         listitem.SubItems.Add(objDR["SKILLS"].ToString());
         listitem.SubItems.Add(objDR["EXPERIENCE"].ToString());
         listitem.SubItems.Add(objDR["POST"].ToString());
         listitem.SubItems.Add(objDR["POSTED"].ToString());
 
         listView2.Items.Add(listitem);
      }

}
else
{
  MessageBox.Show("No Records Found", "", MessageBoxButtons.OK, MessageBoxIcon.Error);
}