error in code

Question

0.00/5 (No votes)

See more:

code is

C#

Int32 i;
       string  d="";
       for (i = 0; i < DataList1.Items.Count; i++)
       {
           CheckBox k;
           k = (CheckBox)(DataList1.Items[i].FindControl("chk"));
           if (k.Checked)
           {
               d += DataList1.DataKeys[i].ToString()+","
               Label1.Text = d;
           }

       }
             d = d.Substring(0, d.Length - 1);

           String qry;
           qry ="select * from tbook where bookid in (" + d + ")";
           SqlDataAdapter ad = new SqlDataAdapter(qry, ConfigurationManager.ConnectionStrings["key"].ConnectionString);
           DataSet dsp = new DataSet();


           ad.Fill(dsp);// error is at this line


           Repeater1.DataSource = dsp;
           Repeater1.DataBind();

any general solution for this problem??

Posted 4-Jul-10 20:48pm

shahina gupta

Updated 4-Jul-10 21:41pm

Richard MacCutchan

v3

Add a Solution

Comments

DaveAuld 5-Jul-10 3:01am

Well, that totally depends on what the rest of the code is!

I suggest you update your question, to also include some of the surrounding code and also exactly what error message you got.

Sandeep Mewara 5-Jul-10 3:02am

Too short a question to reply back! Add more details like what was the error.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sandeep Mewara · Answer 1 · 2010-07-04T21:37:00

Solution 1

First of all about the error:

C#

SqlDataAdapter ad = new SqlDataAdapter(qry, ConfigurationManager.ConnectionStrings["key"].ConnectionString);
DataSet dsp = new DataSet();
ad.Fill(dsp);// error is at this line

This is a WRONG way to use SQLDataAdapter. You have not mentioned the SqlCommand that will be associated adapter to get data. Without that, Fill would not work.

Try something like:

C#

SqlDataAdapter adapter = new SqlDataAdapter();
adapter.SelectCommand = new SqlCommand(queryString, connection);
adapter.Fill(dataset);

Look here:
SqlDataAdapter Class[^]

After resolving this error, would just like to point out that there are few places you need to improve your coding. Like:
1.) Instead of... Int32 i; => int i;
2.) Instead of... string d =""; => string d = string.Empty;
3.) Keep a friendly names of variables and controls like, i as itemCount
4.) Keep checks for null at necessary places like accessing connection string. You directly passed that into query. You should first check if it is available or not (not null when retrieved from DB), then create a SqlConnection using it and use the connection object in adapter.

Posted 4-Jul-10 21:37pm

Sandeep Mewara

Updated 4-Jul-10 21:41pm

v2

Comments

Ankur^\m/ 5-Jul-10 7:08am

Are you sure the OP's way of using SQLDataAdapter is a WRONG way of using it?
AFAIK, the syntax OP has used is one of the overload for SQLDataAdapter where selectCommandText is the first parameter and the connection string is the second. It should run perfectly.

Sandeep Mewara 5-Jul-10 7:53am

Yes Ankur, I am sure. If you feel oterwise, can you share across a link or so where the "connection string" is the second parameter? I believe it should be "SqlConnection object" instead and NOT connection string. I mentioned this in my last point(4) using it that way. Though what i explained was a simpler and obvious way that one can remember and not miss out next time.

Ankur^\m/ 5-Jul-10 8:06am

I confirmed my point using the VS IDE intellisense. But to test it, I just created a test program.
Test results - I can give 'Connection String' as the second parameter (and select query as the first). It works perfectly well. You may test it and then edit your answer. :thumbsup:
[EDIT]
Link: http://msdn.microsoft.com/en-us/library/w2d3kh8d.aspx
[/EDIT]

Sandeep Mewara 5-Jul-10 8:16am

Thanks. Sure i will do that! Meanwhile let the OP revert back with her findings.
BTW, was your other test steps same as OP has done here? Or something different?

Ankur^\m/ 5-Jul-10 8:23am

I just did a test to fill a DataTable using the OP's way. And I could fill the DataTable with the selected records.

Ankur^\m/ 5-Jul-10 8:34am

One more thing, the first point that you pointed out in the improvements section should depend on Coding Standards that you are following. In one of my projects, our client asked us to use Int32 instead of int and String instead of string as a part of Coding standard. I don't see a difference between them but it's the coding standard that you follow will decide how you write your code.