Closing the First Form if the entered information is correct

Question

0.00/5 (No votes)

See more:

Hello,

In a program I have 2 forms. First one is used to get "Username" and "Password" from the user. If the entered information is correct, the second form is shown. Now I want to close the first form or at least hide it not to be seen so I used the code below but it did not close or hide the first form. Could you please let me know how could I make it work?

Thank you a lot

private void button1_Click(object sender, EventArgs e)
        {
            string InputUserName = "Ali";
            string InputPassword = "4862597k";

            string strUserName = textBox1.Text;
            string strPassword = maskedTextBox1.Text;

            if (strPassword == InputPassword && strUserName == InputUserName )
            {
                Form2 f2 = new Form2();
                f2.Show();
                Form1 f1 = new Form1();
                f1.Hide();  // f1.Close();
            }
            else
            {
                MessageBox.Show("Wrong Password or Username, Try again.",
                                "Alert", MessageBoxButtons.OK, 
                                MessageBoxIcon.Warning);

                maskedTextBox1.Text = "";
            }
        }

Posted 23-Jul-10 3:07am

ahhashemi

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jimmanuel · Accepted Answer · 2010-07-23T03:22:00

Well, when you do this:

Form2 f2 = new Form2();
f2.Show();
Form1 f1 = new Form1();
f1.Hide();  // f1.Close();

you're creating two new forms, showing one and hiding the other. Don't you want to hide the form that's already shown instead of hiding a new one that you just created? I think you meant this.Hide() instead of making a new Form1.

Also, see this[^] answer that I posted to a very similar question. It describes in vague terms a better solution for creating and showing a login form.

afshin.b.k · Accepted Answer · 2010-07-23T09:23:00

Solution 3

you should replace this with ur code

if (strPassword == InputPassword && strUserName == InputUserName
{
Form2 f2 = new Form2();
f2.Show();

this.Hide(); ///////

}

just try it .

Posted 23-Jul-10 9:23am

afshin.b.k

Comments

ahhashemi 23-Jul-10 23:19pm

Reason for my vote of 5
Found it helpfull

TheyCallMeMrJames · Accepted Answer · 2010-07-23T03:14:00

For the approach you're taking, I would likely suggest adding a public method called CloseForm() on the form you want to close "remotely". This will allow you to do other shutdown items if required down the road, logic that should be on that class and not this one.

When you create an instance of Form1 to show the username/password dialog, keep a reference to it. Use the reference to invoke the CloseForm() method (rather than creating a new one as you do above).

Cheers.

Closing the First Form if the entered information is correct

3 solutions

Solution 2

Solution 3

Solution 1

Add your solution here

Preview 0