Do I Need To Check For Null When Allocating The Memory Using New?

Question

5.00/5 (1 vote)

See more:

Hi all,

Please suggest the answer for this. In my code I am allocating the memory like as below.

C++

voice_buffer = new char[no_of_bytes + 20];
input_file->ReadData(voice_buffer,no_of_bytes);

Here do I need to check for the NULL conditions or is it required to add this code in to try catch block?

Posted 26-Apr-15 22:23pm

vallikelam

Updated 26-Apr-15 22:32pm

Leo Chapiro

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Leo Chapiro · Accepted Answer · 2015-04-26T22:36:00

Solution 1

Short answer: no.
Take a look: Do I need to check for null after p = new Fred()?:

In C++, if the runtime system cannot allocate sizeof(Fred) bytes of memory during p = new Fred(), a std::bad_alloc exception will be thrown. Unlike malloc(), new never returns null!

Therefore you should simply write:

Fred * p = new Fred(); // No need to check if p is null

Posted 26-Apr-15 22:36pm

Leo Chapiro

Updated 26-Apr-15 22:37pm

v2

Comments

vallikelam 27-Apr-15 5:46am

Thank you for your update, if it runs out of memory what will happen, I am not throwing or handling any exceptions. Is there any crash comes here, because my application is crashing, I am thinking may be this is the place it is causing the issue.

CPallini 27-Apr-15 5:50am

5.

Leo Chapiro 27-Apr-15 5:56am

Thank you! :)

vallikelam 27-Apr-15 6:49am

hi, please update on my comment

Leo Chapiro 27-Apr-15 7:01am

Have you read the article I've pointed to: https://isocpp.org/wiki/faq/freestore-mgmt#new-never-returns-null ? It should answer your question.