Click here to Skip to main content
65,938 articles
CodeProject is changing. Read more.
Articles / Languages / C#

Refactoring Tips - Tip 11

3.33/5 (8 votes)
10 Mar 2010CPOL 1  
Refactoring Tips - Tip 11Tip 11Refactoring 'OR' type of conditions - In a method,if we have multiple conditional statements,with the same result. apply this rule.Bad practiceprivate int Method(){ int result = 1; if( condition1) result = 0; if( condition2) ...
Refactoring Tips - Tip 11

Tip 11

Refactoring 'OR' type of conditions - In a method,if we have multiple conditional statements,with the same result. apply this rule.

Bad practice

private int Method()
{
  int result = 1;
  if( condition1)
    result = 0;
  if( condition2)
    result = 0;
  if( condtion3)
    result = 0;

 return result;
}



Good practice


private int OrCondition()
{
 if( condition1 || condition2 || condition3)
  return 0;
 else
  return 1;
}
private int Method()
{
 return OrCOndition();  
}


I hope this helps!.

Regards,
-Vinayak

License

This article, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)