|
First off, I find it next to impossible to read any code that is not wrapped with 'code block' tags. Does the code even compile? It doesn't look like it will.
And, secondly, Parse() is not a public method of IPAddressControl so you cannot be calling that directly from your code.
And, thirdly, you don't need to modify IPAddressControl at all. This control offers no guarantee of thread safety. Try using a TextBox instead of my control and you'll run into the same problem. Your code either needs to be redesigned to call IPAddressControl on the thread that created the control, or you need to define delegate s for every method that you want to call from another thread and then Invoke() them. In the case of properties (i.e., Text ) a wrapper method that calls from the control's handle creation thread must be used.
Something like this:
private void SetIPAddressControlText( string text )
{
ipAddressControl1.Text = text;
}
delegate void SetTextCallback( string text );
private void ThreadProcedure()
{
if ( ipAddressControl1.InvokeRequired )
{
SetTextCallback c = new SetTextCallback( SetIPAddressControlText );
Invoke( c, new object[] { "127.0.0.1" } );
}
else
{
ipAddressControl1.Text = "127.0.0.1";
}
}
or this (if you don't want to define a wrapper method for the property):
delegate void SetValueCallback( object component, object value );
private void ThreadProcedure()
{
string text = "127.0.0.1";
if ( ipAddressControl1.InvokeRequired )
{
PropertyDescriptor d = TypeDescriptor.GetProperties( ipAddressControl1 )[ "Text" ];
SetValueCallback c = new SetValueCallback( d.SetValue );
Invoke( c, new object[] { ipAddressControl1, text } );
return;
}
ipAddressControl1.Text = text;
}
Henry David Thoreau wrote: Beware of all enterprises that require new clothes.
|
|
|
|
|
The main control doesn't recieve key events (KeyDown, KeyUp, KeyPress, PreviewKeyDown) so there is no ability to handle Keys.Enter or Keys.Return or any other keys that you might want to handle.
I want to handle Keys.Enter and Keys.Return to simulate a button click.
|
|
|
|
|
The control does propagate a KeyPress event for allowed Keys , but not for Keys.Enter or Keys.Return . I'll look into it and get back to you in a few hours.
Cyril Connolly wrote: Truth is a river that is always splitting up into arms that reunite. Islanded between the arms, the inhabitants argue for a lifetime as to which is the main river.
|
|
|
|
|
I've added propagation for KeyUp , KeyDown , and PreviewKeyDown events. And KeyPress will be propagated for Keys.Enter and Keys.Return . I've submitted the code to Code Project, but it may take a couple of days to appear. In the meantime, you can grab the updated files here[^].
Cyril Connolly wrote: Truth is a river that is always splitting up into arms that reunite. Islanded between the arms, the inhabitants argue for a lifetime as to which is the main river.
|
|
|
|
|
Thank you.
I'm converting your project to VB, and I have a question. (I don't program in C#, and usually get confused by all the extra space caused by braces.)
What is if ( null != CedeFocusEvent ) supposed to do?
In VB it's If Nothing <> CedeFocusEvent Then and raises a compiler error:
"'Public Event CedeFocusEvent(sender As Object, e As CedeFocusEventArgs) ' is an event, and cannot be called directly. Use a 'RaiseEvent ' statement to raise an event."
If I comment the if statment in VB, it works properly.
|
|
|
|
|
CedeFocusEvent relies on an external client of the class adding a CedeFocusEvent-handler to the event. So, for safety, the class checks to make sure the event has a handler before raising the event. I don't know anything about VB.Net, but I don't think an equivalent safety check is necessary in VB.Net.
Why bother converting the library? You can just use the compiled C# DLL as a reference in a VB.Net application.
|
|
|
|
|
I'm converting the library because I like to understand what I am using, and I prefer single file executables.
|
|
|
|
|
This is a great piece of code man
Amr Ibrahim
|
|
|
|
|
Thanks. I have some ideas to make the code more efficient by reducing resource use, but I haven't had time to explore them yet.
Henry David Thoreau wrote: Beware of all enterprises that require new clothes.
|
|
|
|
|
Hi there,
It would be great if you could provide a 2008 project zip file as I am having problems placing it under VS 2008. When adding the control to a form the form designer says that there is a problem with DotControl.cs line 70:
70 this.Text = rm.GetString("FieldSeparator");
Could it be an idea to use the *.resx resource file type instead of your Strings.resources?
I used it before under 2005 where it worked great.
Thank you for your great work,
LP
|
|
|
|
|
I've added a VS2008 project file to the source code version available here[^]. The C# source code is linked from the VS2005 project.
Cyril Connolly wrote: Truth is a river that is always splitting up into arms that reunite. Islanded between the arms, the inhabitants argue for a lifetime as to which is the main river.
|
|
|
|
|
Hi Michael,
Thank you for your prompt update. Just some feedback:
1) I think you should make a clean 2008 project, I did that with you update and it looks much better in a 2008 environment instead of referencing the 2005 project.
2) When viewing the control in the 2008 designer then the current code gives you an error saying:
"The class IPAddressControl can be designed, but is not the first class in the file. Visual Studio requires that designers use the first class in the file. Move the class code so that it is the first class in the file and try loading the designer again."
I made the suggested modification and I can report that it does solve the viewing problem.
Otherwise everything else seems works fine now under 2008,
LP
|
|
|
|
|
Regarding #1, what's so clean about redundant code? From a maintainence perspective, not having two copies of the exact same source code is quite clean. Another alternative would be to use soft linking in the Subversion repository, but since most people use the control from a ZIP archive, I'd rather reduce the redundancy there. It would make more sense to put the VS2008 directory as a subdirectory of VS2005, but I wanted to keep the directory convention already established in the Subversion repository.
Regarding #2, this control is not meant to be designed and cannot be opened in the designer when distributed as a DLL, but I agree it's bad form to not place FieldChangedEventsArgs in its own file. So I've made that change. I've also based IPAddressControl on Control rather than UserControl so that it cannot be opened with the designer from within it's own project.
These changes are checked into the Subversion repository[^] and ZIP archives are available from the downloads page[^].
Also, the VS2005 build of the control can be added as a reference to a VS2008 project with no problems. The only changes for the VS2008 project are a new GUID, a new version number, and a new resource file (in case the format changed with VS2008).
Cyril Connolly wrote: Truth is a river that is always splitting up into arms that reunite. Islanded between the arms, the inhabitants argue for a lifetime as to which is the main river.
|
|
|
|
|
I've submitted a new version (Revision 26) to the Code Project, but in the meantime, you can find the updates here[^].
If the control was ReadOnly , the [Backspace] and [Delete] keys could still change the control's contents. That bug is now fixed.
Cyril Connolly wrote: Truth is a river that is always splitting up into arms that reunite. Islanded between the arms, the inhabitants argue for a lifetime as to which is the main river.
|
|
|
|
|
Thank you very much for your good control.
It's Readonly, but a text in a field can be deleted.
The key which could be used Delete or Back Space.
I'm trying in order to correct the FieldControl.OnKeyDown().
-toru suzuki
|
|
|
|
|
Sorry about that. OnKeyDown() is the place to fix it. In FieldControl.cs, change line 372 to
if ( !ReadOnly && e.KeyCode == Keys.Back ) and change line 377 to
if ( !ReadOnly && e.KeyCode == Keys.Delete )
Cyril Connolly wrote: Truth is a river that is always splitting up into arms that reunite. Islanded between the arms, the inhabitants argue for a lifetime as to which is the main river.
|
|
|
|
|
Thank you very much for your prompt reply.
I'm convinced that this cord is the most excellent ip address control.
|
|
|
|
|
No problem. The only reason this control is any good is because of the people who found bugs or suggested enhancements. Thanks for reporting the bug.
Cyril Connolly wrote: Truth is a river that is always splitting up into arms that reunite. Islanded between the arms, the inhabitants argue for a lifetime as to which is the main river.
|
|
|
|
|
An update has been submitted to the Code Project, but, in the meantime, the projects are available here[^].
I've added an AllowInternalTab property to allow the tab key to be used within the control. It is false by default. AnyBlank was added as a property to get whether any field in the control is blank. A null exception check was added to SetAddressBytes() . Superfluous code, such as an auto-generated Dispose() method, has been excised. The Graphics object returned by Graphics.FromHwnd() now has Dispose() called on it. I don't think it matters because I wrote a test calling FromHwnd() without Dispose() (but with garbage collection) many thousands of times with no resource leaks detected.
Also added was propagation of certain events -- GotFocus , LostFocus , KeyPress , MouseEnter , MouseMove , MouseHover , MouseLeave , Click , DoubleClick , MouseClick , and MouseDoubleClick . I thought adding mouse events would help with having tooltips work properly, but it does not.
And the default context menu for the contained TextBox es has been suppressed.
|
|
|
|
|
Hi!
I am using a simplified Chinese XP and is experiencing problems with the width of the control. The fourth IP field isn't visible even though AutoSize is true.
Do you know what the problem could be?
mattias
|
|
|
|
|
Which version are you using, .Net 1.1 or .Net 2.0? The calculation of width varies, but in both cases the minimum width of the control is the sum of the calculated minimum widths of each field and dot control. It would make more sense to me if each field was too small, rather than the clipping of just one field. What happens if you try to resize the control in the form designer? Does the non-visible field always remain non-visible?
Also, AutoSize should have no effect on the control, or at least it is not being handled anywhere in the latest version of the code. The most recent versions of the code are available here[^]. The versions available from Code Project also do not use AutoSize anymore.
|
|
|
|
|
I'm using .NET 2, and probably also the version attached to this article.
It is only the last IP field that isn't fully visible, indifferent of the control width. This lead me to the function IPAddressControl.LayoutControls and the arrangement of fields and dots when the control is wider than MinimumSize.Width .
If I don't consider the calculation of offsets in LayoutControls and add a call to AdjustSize after LayoutControls in OnSizeChanged , it seems to work both in English as well as Chinese XP. Of course this means that the control can't have a custom width, and I don't think it brings any clarity to why the problem arises
I also have to mention that the problems only is seen on simplified Chinese XP (will test Japanese tomorrow), not English, nor Swedish.
By the way, thanks you for your quick response.
|
|
|
|
|
The current version attached to this article (Revision 12) has the AutoSize fix, so that should not be the problem. The newer version on Google Code has fixes for focus-related events and some enhancements, nothing related to layout.
Also, while looking at this issue, I found a potential resource leak (not Dispose() -ing a Graphics object) that I've fixed. So when this current issue is resolved I'll update the code here to include the leak fix. Thanks for forcing me to look at the code with fresh eyes.
I have an CD for Traditional Chinese XP. Do you know if that has the same problem? If so, I'll install it and debug. In the meantime, I'll see if I can find a Simplified version.
I have another project[^] that is a more generic version of this control that can be configured as an IP address control. Perhaps there is a subtle bug in this project that is not in the other project. Would you mind trying that code in Chinese XP to see if it behaves similarly? That code also has the resource leak, but I'm deferring an update until this issue is resolved in case the problem exists in both code bases.
|
|
|
|
|
I installed Simplified Chinese XP and did not witness the behavior you've described. I used the VS2005 demo project above and the only change I had to make was to move the IPAddressControl to the right a little because the Label overlapped it. It looks like crap because of the default font that Windows uses, but the layout is the same as it is with English XP.
|
|
|
|
|
Strange that you didn't experience the same problem. I downloaded the same VS2005 project above and ran it (snapshot[^]).
I also tested your other sample and took a snapshot[^]. The funny thing is that this example seems ok, but not the first. What are the main differences regarding arranging elements between the two examples?
|
|
|
|