|
That was the only reason i could come up with for it not working on my Win XP system. the only other variable is that I have the task bar at the top of the screen. Anyway I've worked out a way to do the same, without any image processing, See below.
The codes is in vb6 but you should be able to easily convert it. The call to GethWndTray (which gets the tray's toolbar control has been ommited for compactness.
Private Type TrayData
hWnd As Long
ID As Long
End Type
Public Function GetSystemTrayItemRect(ByVal hWnd As Long, ByVal ID As Long) As RECT
Dim hWndTray As Long
Dim hProc As Long
Dim pid As Long
Dim vaPtr As Long
Dim ret As Long
Dim tbut As TBBUTTON
Dim cButtons As Long
Dim td As TrayData
Dim i As Long
Dim rc As RECT
hWndTray = GethWndTray
If hWndTray = 0 Then Exit Function
Call GetWindowThreadProcessId(hWndTray, pid)
If pid = 0 Then Exit Function
hProc = OpenProcess(PROCESS_VM, 0, pid)
If hProc = 0 Then Exit Function
vaPtr = VirtualAllocEx(hProc, ByVal 0&, Len(tbut), MEM_COMMIT, PAGE_READWRITE)
If vaPtr = 0 Then GoTo cleanup
cButtons = SendMessage(hWndTray, TB_BUTTONCOUNT, ByVal 0&, ByVal 0&)
On Error GoTo cleanup
For i = 0 To cButtons - 1
Call SendMessage(hWndTray, TB_GETBUTTON, i, ByVal vaPtr)
Call ReadProcessMemory(hProc, ByVal vaPtr, tbut, Len(tbut), ret)
If Not tbut.dwData = 0 Then
Call ReadProcessMemory(hProc, ByVal tbut.dwData, td, Len(td), ret)
If hWnd = td.hWnd Then
If ID = td.ID Then
Call SendMessage(hWndTray, TB_GETITEMRECT, i, ByVal vaPtr)
Call ReadProcessMemory(hProc, ByVal vaPtr, rc, Len(rc), ret)
Exit For
End If
End If
End If
Next
Call MapWindowPoints(hWndTray, 0&, rc, 2)
GetSystemTrayItemRect = rc
cleanup:
If hProc Then
If vaPtr Then
Call VirtualFreeEx(hProc, ByVal vaPtr, 0&, MEM_RELEASE)
End If
End If
If hProc Then CloseHandle (hProc)
End Function
|
|
|
|
|
Hi
I have ported VB example you provided to C++ and it looks promising. The problem is that all you can retrive with this example it's rectangle of each button in a tray (cool!) and TBBUTTON structure. But TBBUTTON seems to be not enought to determinate witch one of the buttons belongs to our application. Especialy there is no HWND member and button ID member seems to have different values that this ID we specify while adding icon to the tray.
in VB code there is a piece of code:
If hWnd = td.hWnd Then<br />
If ID = td.ID Then
but in C++ definition of TBBUTTON of this structure there are no such members.
Anyone hve any idea how to solve it?
Best regars,
Irek
Check out my software at: http://www.ireksoftware.com
|
|
|
|
|
Copy the first 8 bytes of the dwData member of the TBBUTTON, using the ReadProcessMemory API as you did to get the TBBUTTON struct. The first 4 bytes is the hWnd the button belongs to. The second 4 bytes is the NOTIFYICONDATA.iUD.
Then using the index of the button you can then get the it's rect by calling TB_GETITEMRECT, again ReadProcessMemory is required. As seen in my earlier post.
There appear's to be alot more info in dwData but I just use the first 8.
Hope that helps.
Regards
Neal
|
|
|
|
|
|
VirtuaWin uses an icon with a lot of black,
this is sometimes seen as the icon we're looking for!
|
|
|
|
|
I recommend to change a bit code that detects an icon. Now code serches only few lines and test if it's black or near black. Adding more lines to search should help in this case.
Check out my software at: http://www.ireksoftware.com
|
|
|
|
|
CheckIfColorIsBlackOrNearBlack could be implemented like this:
BOOL CTrayIconPosition::CheckIfColorIsBlackOrNearBlack(COLORREF crColor)
{
return !(((DWORD)crColor)&0xFCFCFC);
}
and make it inline. code will become mutch faster (well not really a problem here)
or fastest would be to use it as define
#define CheckIfColorIsBlackOrNearBlack(crColor) (!(((DWORD)crColor)&0xFCFCFC))
Or a bit slower
BOOL CTrayIconPosition::CheckIfColorIsBlackOrNearBlack(COLORREF crColor)
{
return (GetRValue(crColor)<4) && (GetGValue(crColor)<4) && (GetBValue(crColor)<4);
}
BTW: nice idea to solve the problem!
What do you think of using an icon with a white border (2pix for 32*32 icon) and calculate the exact rectangle of the icon?
Harald
|
|
|
|
|
Hi
Thanks for the feed-back.
I have just submited an update to souce code with:
BOOL CTrayIconPosition::CheckIfColorIsBlackOrNearBlack(COLORREF crColor)
{
return !(((DWORD)crColor)&0xFCFCFC);
}
>What do you think of using an icon with a white border (2pix for 32*32 icon) and calculate the exact rectangle of the icon?
I think that this could fail since there is no proof that border will not be disrupted by Windows. But I was thinking on a different approach. First you put a plain black icon into the tray and detect all black points, then put a bit lighter icon (dark gray) and check previously black pixels if now those are dark gray - is should stil take a blink of eye and be able to detect an rectangle of icon with a great precision.... I don't plan to implement this feature but (since simple point detection is enought in my applicatins) but I would gladly update souce code if someone would do this
Best regards!
Irek
Check out my software at: http://www.ireksoftware.com
|
|
|
|
|
Add this:
TrayIconPosition.h
CRect m_rcLastTrayPos
TrayIconPosition.cpp
GetTrayIconPosition(CPoint &point, Precision prPrec)
{
...
if(m_rcLastTrayPos!=m_rtRectangleOfTheTray)
bUpdateRequired=1;
if(bUpdateRequired)
{
... m_rcLastTrayPos = m_rtRectangleOfTheTray;
|
|
|
|
|
This isn't good because the icon rect could move inside the tray rect
Instead we could track the mouse position from where the function gets called and see if fits the old icon rect. If not..scan for the new rect icon; at least this will lower the scan operations...especially on vista or later which requires visual scan only...that black icon.
|
|
|
|
|
re hello,
I have some mistake with my application. In the OnInitDialog function i do that( i have include CBalloonHelp):
NOTIFYICONDATA nid; <br />
nid.cbSize = sizeof(nid); <br />
nid.hWnd = m_hWnd; <br />
nid.uID = 1; <br />
nid.uFlags = NIF_ICON|NIF_TIP; <br />
Shell_NotifyIcon(NIM_ADD, &nid);<br />
<br />
m_tipPosition.InitializePositionTracking(m_hWnd,1);<br />
<br />
TraySetIcon(IDR_ICON2);<br />
sprintf(status,"Applicom = %d .Twincat = %d",Appli.GetStatusUnitel(),Appli.GetStatusTwin());<br />
TraySetToolTip(status);<br />
<br />
TraySetMenu(IDR_MENU1);<br />
TrayShow();
ShowWindow(SW_HIDE);
But when i call GetTrayIconPosition in CTrayIconPosition, it load a black icon. After what i refresh my icone in the OnTimer() like that:
sprintf(status,"Applicom = %s Twincat = %s",mot,mot2);<br />
TraySetToolTip(status);<br />
TrayUpdate();
Finaly, my problem is the menu is not attach to my icon and i have to restart my PC because Windows can't killed the thread.
Have you some ideas.
Thanks by advance.
|
|
|
|
|
re
it is like that:
sprintf(status,"Applicom = %s Twincat = %s",mot,mot2);<br />
TraySetToolTip(status);<br />
TraySetMenu(IDR_MENU1);<br />
TrayUpdate();
|
|
|
|
|
hello,
In the first time i would like ti said this code is great. It's the le final part of my project.
I have just a problem. The Tail of the balloon appears behind the tray.
I don t understand why beacause i creat the balloon after the tray.
If you have some ideas, i thank you by advance.
|
|
|
|
|
As far I know - balloon can be constructed with TOPMOST attribute - it should help
Check out my software at: http://www.ireksoftware.com
|
|
|
|
|
ok, thanks that's work with TOPMOST.
One more time great job
|
|
|
|
|
Thanks Irek! I was looking for such code for a long time... Well done
Przemek
|
|
|
|
|
This "Tray Icon" doesn't position itself correctly when the taskbar is on the left or on the right of the desktop. And the pointer in such situation looks real ugly.
Regards,
Vitaly Tomilov
Ultimate all-in-one XP-Style UI multiplatform solution: Tooltips, XP Menus, Hyperlinks, Drawing Graphics and formatted documents, plus powerful binary resource reuse. All Free 100% on www.tooltips.net. It can be used in VC++, C#, Java+, VB, Delphi, C++ Builder, as well as in any COM-compatible platform.
|
|
|
|
|
That's not true. Position is beign calculated correctly.
This is rater bug in CBalloonHelp class that is not able to display balloon with such anchor points in a nice way.
Please relly on coordinates that application returns rather than the outlook of third-party-created balloon.
Check out my software at: http://www.ireksoftware.com
|
|
|
|
|
- The position is not calculated correctly, as the balloon won't overlap the taskbar ever!
- I relied on your demo project, in which, if I use my taskbar on the left or right side of the desktop the balloon's pointer looks horrible!
- Did you ever try your example on a multimonitor system?
Regards,
Vitaly
Professional tooltips for all development platforms Free on www.Tooltips.NET
|
|
|
|
|
I think I have to make some things clear.
First of all this article describes CTrayIconPosition class and have nothing to do with CBalloonHelp class by Shog.
The most important data that is being calculated by demo application are X/Y coordinates of tray icon. While creating demo application I had to decide how to display those coordinates - at first I was thinking about simple MessageBox with such kind of message: "Icon found! Coordinates X[xxx] Y[yyy]."
But since I use balloon class in my applications I thought that it would be a good idea to not only show the raw coordinates but also display example of usage of this class.
So while testing this class - please compare COORDINATES given in result with position of your tray icon. Balloon is only example of use of this coordinates.
As you suggest balloon looks ugly when task bar is in left or right part of the screen - that's true. But it has nothing to do with CTrayIconPosition class described here.
I think that far better place to point this bug is CBalloonHelp discussion forum (link on the beginning of article).
About multi-monitors:
CTrayIconPosition was not checked under multi-monitor environment. But I don't predict any problems - if I'm wrong - let me know about that.
I hope this will clarify some things and there will be no more misunderstandings.
Best regards,
Irek
Check out my software at: http://www.ireksoftware.com
|
|
|
|
|
What about sending WM_MOUSEMOVE directly to that window with client coordinates that jump by 16 pixels across the area? Then you have no bitmap scanning or anything like that, and you just catch your WM_MOUSEMOVE being sent in your code. Probably a little faster.
-Ian
|
|
|
|
|
|
Well
I spent some time investigting this possibility.
Since it seems to work - it has one serious disadventage.
I have few applications in my tray and one of them started to dispaly a tool tip while recieving WM_MOUSEMOVE mesage. I'm afraid that is not acceptable.
I'm going to spend more time on this matter but seems to me sending fake messages could lead some tray applications to behave strangely.
Check out my software at: http://www.ireksoftware.com
|
|
|
|
|
Irek Zielinski wrote:
I have few applications in my tray and one of them started to dispaly a tool tip while recieving WM_MOUSEMOVE mesage. I'm afraid that is not acceptable.
Yea, that's no good. Do you send more than one mousemove to the same icon area?
|
|
|
|
|
Actualy I was trying few ways to send this WM_MOUSEMOVE message. I'm afraid if I was able to find one application that actualy cares about WM_MOUSEMOVE - there could be more such applications installed on PCs of my users. The problem is that there is no way to guess if fake messages you send will be ignored by tray applications or not.
But thanks for poiting this idea - it could prove usefull someday!
Check out my software at: http://www.ireksoftware.com
|
|
|
|